Fix currency conversion#8
Open
wharris wants to merge 1 commit into
Open
Conversation
Commit a1b9a67 added the country selection feature. The rates given in conversionRate.json were in currency/USD but script.js calculates the USD offset by multiplying the foreign currency offset by the conversion rate. The result was that converted offsets were incorrect. EUR and GBP offsets were converted to a too-low USD offset and CAD offsets were converted to a more generous USD offset. For example, £307.88 was calculated as $227.83 instead of $418.72. This commit fixes the problem by reversing the sense of the rates in conversionRate.json so they are now in USD/currency. Within rounding, the reciprocals of the old rates were equal to the values I looked up at around 2025-09-12T18:30+00:00. I chose to change the data over changing the calculation to avoid any possibility of a division-by-zero.
✅ Deploy Preview for themarcooffset ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a1b9a67 added the country selection feature. The rates given in conversionRate.json were in currency/USD but script.js calculates the USD offset by multiplying the foreign currency offset by the conversion rate. The result was that converted offsets were incorrect. EUR and GBP offsets were converted to a too-low USD offset and CAD offsets were converted to a more generous USD offset. For example, £307.88 was calculated as $227.83 instead of $418.72.
This commit fixes the problem by reversing the sense of the rates in conversionRate.json so they are now in USD/currency. Within rounding, the reciprocals of the old rates were equal to the values I looked up at around 2025-09-12T18:30+00:00. I chose to change the data over changing the calculation to avoid any possibility of a division-by-zero.