signi.py: checkfiles expects a string, not a bytes-like object#4
Open
nevun wants to merge 1 commit intobjornedstrom:masterfrom
Open
signi.py: checkfiles expects a string, not a bytes-like object#4nevun wants to merge 1 commit intobjornedstrom:masterfrom
nevun wants to merge 1 commit intobjornedstrom:masterfrom
Conversation
This matches what is done here: https://github.com/bjornedstrom/python-signify/blob/master/signify/pure.py#L440 before: ``` Signature Verified Traceback (most recent call last): File "/usr/bin/signi.py", line 181, in <module> main() File "/usr/bin/signi.py", line 121, in main for path, status in check.checkfiles(os.getcwd(), message): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/site-packages/signify/check.py", line 36, in checkfiles for algo, path, ref_digest in re.findall( ^^^^^^^^^^^ File "/usr/lib64/python3.12/re/__init__.py", line 217, in findall return _compile(pattern, flags).findall(string) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: cannot use a string pattern on a bytes-like object ``` after: ``` Signature Verified foo.pem: OK bar.pem: OK ```
973a1da to
c37fc95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches what is done here: https://github.com/bjornedstrom/python-signify/blob/master/signify/pure.py#L440
before:
after:
SHA256.sig looks like this: