Sourcery refactored develop branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-32
to
+37
| if (platform.system().lower().startswith("windows") | ||
| or os.name.lower().startswith("windows")): | ||
| return True | ||
| return False | ||
| return bool( | ||
| ( | ||
| platform.system().lower().startswith("windows") | ||
| or os.name.lower().startswith("windows") | ||
| ) | ||
| ) |
Author
There was a problem hiding this comment.
Function isWin refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity)
Comment on lines
-39
to
+42
| if (debug): | ||
| print("munge input: %s" % name) | ||
| if debug: | ||
| print(f"munge input: {name}") |
Author
There was a problem hiding this comment.
Function mungeName refactored with the following changes:
- Replace interpolated string formatting with f-string [×2] (
replace-interpolation-with-fstring)
Comment on lines
-57
to
+63
| print("%s" % command) | ||
| print(f"{command}") | ||
| p1 = subprocess.Popen(command,shell=True) | ||
| p1.wait() | ||
| if (not(p1.returncode == None) and not(p1.returncode == 0)): | ||
| stopErr('%s failed' % command, p1.returncode) | ||
| if p1.returncode is not None and p1.returncode != 0: | ||
| stopErr(f'{command} failed', p1.returncode) |
Author
There was a problem hiding this comment.
Function doCommand refactored with the following changes:
- Replace interpolated string formatting with f-string [×2] (
replace-interpolation-with-fstring) - Simplify logical expression using De Morgan identities [×2] (
de-morgan) - Use x is None rather than x == None (
none-compare)
Comment on lines
-65
to
+67
| if (j == None): | ||
| command = 'make %s' % target | ||
| else: | ||
| command = 'make -j%d %s' % (j,target) | ||
| command = f'make {target}' if j is None else 'make -j%d %s' % (j,target) |
Author
There was a problem hiding this comment.
Function makeTest refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Use x is None rather than x == None (
none-compare) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-72
to
+71
| if (j == None): | ||
| command = 'make build' | ||
| else: | ||
| command = 'make -j%d build' % j | ||
| command = 'make build' if j is None else 'make -j%d build' % j |
Author
There was a problem hiding this comment.
Function makeBuild refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Use x is None rather than x == None (
none-compare)
Comment on lines
-80
to
+76
| if (j == None): | ||
| command = 'make %s' % target | ||
| else: | ||
| command = 'make -j%d %s' % (j,target) | ||
| command = f'make {target}' if j is None else 'make -j%d %s' % (j,target) |
Author
There was a problem hiding this comment.
Function makeTestModel refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Use x is None rather than x == None (
none-compare) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-88
to
+95
| targets = list() | ||
| targets = [] | ||
| for name in filenames: | ||
| if (not name.endswith(testsfx)): | ||
| continue | ||
| target = "/".join([dirname,name]) | ||
| target = mungeName(target) | ||
| targets.append(target) | ||
| if (len(targets) > 0): | ||
| if targets: | ||
| if (debug): | ||
| print('# targets: %d' % len(targets)) | ||
| startIdx = 0 | ||
| endIdx = batchSize | ||
| while (startIdx < len(targets)): | ||
| if (j == None): | ||
| command = 'make %s' % ' '.join(targets[startIdx:endIdx]) | ||
| if j is None: | ||
| command = f"make {' '.join(targets[startIdx:endIdx])}" |
Author
There was a problem hiding this comment.
Function makeTests refactored with the following changes:
- Replace
list()with[](list-literal) - Simplify sequence length comparison (
simplify-len-comparison) - Use x is None rather than x == None (
none-compare) - Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Replace comparison with min/max call (
min-max-identity)
Comment on lines
-124
to
+116
| command = '%s --gtest_output="xml:%s.xml"' % (executable, xml) | ||
| command = f'{executable} --gtest_output="xml:{xml}.xml"' |
Author
There was a problem hiding this comment.
Function runTest refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-144
to
+136
|
|
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Replace interpolated string formatting with f-string [×7] (
replace-interpolation-with-fstring)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
developrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
developbranch, then run:Help us improve this pull request!