Christmas 2011 interface updates; remove 2012 dir - #3
Merged
Conversation
- Move "the Kirkby's" signature up beneath the Merry Christmas banner - Reserve grid space with per-cell loading placeholders (no more pop-in) - Round the center music-notes cell to match the face cells - Remove the two how-to intro paragraphs - Delete the unused kirkbychristmas/2012 directory Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the kirkbychristmas/2011/ Christmas page layout/UX (signature placement, smoother initial rendering of the face grid, and simplified intro copy) and removes the unused kirkbychristmas/2012/ copy from the repo.
Changes:
- Adjust the 2011 layout to place the “the Kirkby’s” signature directly under the banner (desktop + mobile stacking order).
- Replace the separate loading spinner + fade-in behavior with per-cell loading placeholders for the face grid (and round the center/play/pause cell to match).
- Delete the
kirkbychristmas/2012/directory’s HTML/CSS files.
Reviewed changes
Copilot reviewed 5 out of 126 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kirkbychristmas/2011/sing.css | Repositions signature/grid, adds per-cell loading placeholders, and rounds center/play/pause cell; updates mobile stacking order. |
| kirkbychristmas/2011/index.html | Removes the standalone loading spinner and trims the two “how-to” intro paragraphs. |
| kirkbychristmas/2012/sing.css | Deleted (2012 page cleanup). |
| kirkbychristmas/2012/index.html | Deleted (2012 page cleanup). |
| kirkbychristmas/2012/default.html | Deleted (2012 page cleanup). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates to the live Christmas 2011 page (
kirkbychristmas/2011/) plus cleanup of the unused 2012 copy.kirkbychristmas/2012/directory (nothing links to it; the redirect points to2011/)Testing
Rendered desktop (>1000px) and mobile (390px) layouts headlessly — signature placement, rounded cells, loading placeholders, and trimmed intro text all verified.
🤖 Generated with Claude Code