CommandsApp exit code 0 when parsing fails

[daddykotex]

Thanks for decline, it's truly amazing.

We use it as part of a few of our applications and I just realized that when using CommandApp, if the parsing fails, we print the help but still return 0 as the exit code. See https://github.com/bkirwi/decline/blob/master/core/shared/src/main/scala/com/monovore/decline/CommandApp.scala#L53

We had not realized before today because the CommandIOApp returns a different exit code when parsing fails: https://github.com/bkirwi/decline/blob/master/effect/shared/src/main/scala/com/monovore/decline/effect/CommandIOApp.scala#L42

Would you be open to a PR to do sys.exit(1) instead?

[bkirwi]

Thanks for the kind words and the report!

I do agree that the behaviour you suggest would be better. However, it is technically a breaking change, and I'm not sure when to expect the next major version bump, so I can't guarantee that this would be merged and released in short order. If you're comfortable with that, though, happy to have the PR!

I imagine you already have a workaround, but in case not, or for other readers who happen on this -- calling command.parse directly is the easy alternative, either directly in a main method or in a CommandApp-like abstraction of your own.

[daddykotex]

see #405

you merge and release when you see fit. if you can ping when this is actually out, great, otherwise I left a comment in our code that points here so we'll come around if you forget.