Move OpenCV to an optional dependency #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables a "slim" installation of the package by making OpenCV an optional dependency. Users can install OpenCV with the new "full" variant of the package to get support for model fitting. The default installation will only support forecasting from an existing model. Since this latter scenario is the most common use case for popcast and requires a substantially smaller footprint on disk, this default is what we'll want for environments like the Nextstrain Docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables a "slim" installation of the package by making OpenCV an optional dependency. Users can install OpenCV with the new "full" variant of the package to get support for model fitting. The default installation will only support forecasting from an existing model. Since this latter scenario is the most common use case for popcast and requires a substantially smaller footprint on disk, this default is what we'll want for environments like the Nextstrain Docker image.