Conversation
…ution using htslib
…e also now copy the front of the dhtslib.file iterators with dup
Codecov Report
@@ Coverage Diff @@
## develop #138 +/- ##
===========================================
+ Coverage 83.37% 83.78% +0.41%
===========================================
Files 45 46 +1
Lines 4823 4945 +122
===========================================
+ Hits 4021 4143 +122
Misses 802 802
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
What is the use case? I may not be qualified to comment on this 🤯 |
| } | ||
| } | ||
|
|
||
| kstring_t* ks_dup(kstring_t* s) { |
There was a problem hiding this comment.
Interestingly is not a part of kstring.h or kstring.c ; will this make it more difficult to keep your file in sync with upstream?
There was a problem hiding this comment.
Since we have the diff system, probably not. Though I should update the diffs considering I have new changes that need to carry forward.
Though I also thought that kstring already had a dup function and was surprised to find that it didn't.
This PR adds wrappers around
htsThreadPoolandhts_tpool. The goal would be to allow parallel, in-order execution of arbitrary functions. These jobs could be added directly to the same thread pools that are used for reading and writing files.