fix: memory cycle in diverts#23
Open
brentjanderson wants to merge 1 commit into
Open
Conversation
There is an Rc<T> cycle between a Container, a Divert, back to a Container. This reliably produces a memory leak when running multiple stories in parallel (memory_leak_test covers this case). By caching potential targets and using Weak<T> to break the cycle, we avoid this memory leak case. This shouldn't change the performance profile of a running story, as target references are already lazily loaded. We are just moving from the Divert struct to a shared cache with weak references.
brentjanderson
force-pushed
the
fix-reference-cycle-leak
branch
from
69e07cd to
6260147
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an
Rc<T>cycle between a Container, a Divert, back to a Container. This reliably produces a memory leak when running multiple stories in sequence or parallel (memory_leak_test helps verify this).By caching potential targets and using
Weak<T>to break the cycle, we avoid this memory leak case.This shouldn't change the performance profile of a running story, as target references are already lazily loaded. We are just moving from the Divert struct to a shared cache with weak references.