fix(wire): restore dispatch read timeout from 10s to 90s - #104
Merged
Conversation
The E2E refactor in #103 replaced dispatch.ReadOne's 90s deadline (DefaultPongTimeout + 30s) with readE2E's hardcoded 10s ReadMessage deadline. The server sends pings every ~30s, so connections died before the first ping. Add readTimeout/writeTimeout fields to Client (90s/10s defaults, matching the pre-E2E dispatch values) and wire them into readE2E and writeE2E. Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The E2E refactor (#103) accidentally changed the dispatch read deadline from 90 seconds to 10 seconds. The server sends pings every ~30s, so connections died before the first ping arrived.
Root cause
readE2E/writeE2Ehardcoded10*time.Secondinstead of using the configurable timeout the oldreadOneused (DefaultPongTimeout + 30s= 90s).Fix
Add
readTimeoutandwriteTimeoutfields toClient(90s/10s defaults, matching the pre-E2E dispatch values) and wire them intoreadE2EandwriteE2E.