Repository navigation
fix(security): resolve gosec findings in apisync and contractcheck tooling - #49
Merged
Merged
Conversation
…oling WriteFile permissions tightened to 0600 (G306) and file-inclusion / path-traversal / subprocess warnings annotated with justified #nosec (G304/G703/G204): all paths are developer-supplied CLI args or repo-relative names in local codegen tooling, never external input. gosec now reports zero issues.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.WriteFilepermissions tightened from 0644 to 0600 in the 4 flagged call sites (G306) - the artifacts are repo files, git does not preserve non-exec mode bits, so this is behavior-neutral#nosec: every flaggedos.ReadFiletakes a path built from the developer-suppliedrepoRootCLI argument or a repo-relative constant.cmd/apisyncandcmd/contractcheckare local codegen/CI tools; no path ever comes from untrusted inputgo build,go vetandgosec ./cmd/...all pass (0 issues, 12 justified nosec).Context
Resolves the 13 open code security findings in the compliance platform for this repo. Fixing rather than suppressing platform-side since this SDK repo may become public.