Repository navigation
fix(api-sync): drop stale spec-map ignore.schemas entries - #74
Merged
Merged
Conversation
The v5.3.0 spec refresh (#72) removed CreateInstanceRfiBody, CreateRfiBody, and LedgerOperation from the API spec, but .api-sync/spec-map.json's ignore.schemas still listed all three, failing map.test.ts's "every ignore.schemas name exists in the spec's components.schemas" check on main. Verified every remaining ignore.schemas entry (including the other Rfi-family ones: InstanceRfi, Rfi, RfiField, RfiSection) still resolves against the committed spec-snapshot.json; only these three were stale. Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateInstanceRfiBody,CreateRfiBody, andLedgerOperationfrom the API spec, but.api-sync/spec-map.json'signore.schemasstill listed all three.map.test.ts's "every ignore.schemas name exists in the spec's components.schemas" assertion on main, which in turn fails thetestsjob of the Main workflow.Fix
ignore.schemasentries.InstanceRfi,Rfi,RfiField,RfiSection) against the current.api-sync/spec-snapshot.json— those all still resolve, so only the three above were stale.ignore.operations(the Rfi-family paths andPOST /v1/upload/analyze) against the current spec — all still present, no changes needed there.Test plan
bun run test— 182/182 passing (was 2 failing before this fix)bun run lint:check— passes (3 pre-existing, unrelated warnings)bun run sync:check— passes, no pending drifthttps://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs