Skip to content

chore(ci): take the release PR number from release-please's output - #62

Merged
ericviana merged 1 commit into
mainfrom
eric/release-merge-from-output
Aug 4, 2026
Merged

ericviana merged 1 commit into
mainfrom
eric/release-merge-from-output

Conversation

@ericviana

Copy link
Copy Markdown
Member

Follow-up to #60, which moved the release-PR merge into the push-triggered job but still located the PR with gh pr list --label 'autorelease: pending'. That raced GitHub's indexing and lost: release-please created PR #61 at 00:14:03Z, the merge step queried at 00:14:05.9Z, and the step logged "No pending release PR to merge." The release then sat open, which is the exact stall #60 was meant to remove.

Now the PR number comes from steps.release.outputs.pr, which the action sets in the same job and which needs no indexing and no label. The label query survives as a retried fallback (3 attempts, 5s apart) for the case where the action updates an existing PR without re-emitting the output.

Note the commit prefix here is chore(ci): on purpose. #60 used fix(ci):, which release-please counted as a patch and turned into a pointless 3.1.1 release of a CI-only change. CI-only commits should use chore so they do not cut a release.

This one cannot be proven by reading, only by watching the next cycle: after this merges, the publish run should merge the open release PR by itself and 3.1.1 should land on PyPI with nobody clicking. I will confirm that it did.

https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs

Listing by label raced GitHub's indexing: the previous run created the release
PR at 00:14:03 and a label query 3 seconds later returned nothing, so 3.1.1 sat
open. The action's own output is immediate; the label query stays as a retried
fallback.

Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs
@BernardoSM

Copy link
Copy Markdown
Collaborator

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ericviana
ericviana merged commit 97658a0 into main Aug 4, 2026
8 checks passed
@ericviana
ericviana deleted the eric/release-merge-from-output branch August 4, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants