fix(upload): add required type and optional metadata to analyze input - #68
Merged
Merged
Conversation
UploadAnalyzeInput only declared `file`, so calling analyze() as typed never sent the API's required `type` (document kind enum) and had no way to pass the optional `metadata` verification hints. Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UploadAnalyzeInputonly declaredfile. The API'sPOST /v1/upload/analyzerequirestype(document kind enum) and accepts optionalmetadata. As typed,analyze()could never build a valid request.UploadAnalyzeDocumentTypeLiteral covering the spec's 21 enum values, madetyperequired, andmetadataoptional (NotRequired[Optional[str]]).Test plan
analyze()withtypeandmetadatapytest,pyright,mypy,ruffall pass.api-sync/sync.py --checkand.api-sync/check_contract.pypass unchanged (this schema is a recorded exclusion in spec-map.json, unaffected by this fix)Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs