Skip to content

feat: add openexchangerates provider#74

Merged
dolcalmi merged 5 commits into
blinkbitcoin:mainfrom
tiankii:feat--add-new-exchange-rate-provider
Jun 12, 2025
Merged

feat: add openexchangerates provider#74
dolcalmi merged 5 commits into
blinkbitcoin:mainfrom
tiankii:feat--add-new-exchange-rate-provider

Conversation

@tiankii
Copy link
Copy Markdown
Contributor

@tiankii tiankii commented Jun 12, 2025

Integrate OpenExchangeRates as an additional exchange rate provider

Description

This pull request integrates OpenExchangeRates as an additional exchange rate provider used for calculating the average exchange rate across multiple sources.

Main changes

  • Implemented the OpenExchangeRatesService module with support for fetching live rates via HTTP.
  • Included error classes specific to this provider to improve observability and error categorization.
  • Introduced unit tests to validate correct integration and error scenarios without altering the overall average rate aggregation logic.

@tiankii tiankii marked this pull request as ready for review June 12, 2025 14:42
@tiankii tiankii changed the title feat: add openexchangerates provider for fiat currencies feat: add openexchangerates provider Jun 12, 2025
Comment on lines +107 to +108
bid: toPrice(1 / rate),
ask: toPrice(1 / rate),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just rate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done!

@dolcalmi dolcalmi merged commit d44ca08 into blinkbitcoin:main Jun 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants