It looks like the diff algorithm here doesn't compare values strictly, A minimal example is:
{"t":"0"} is not different from {"t":false}
I guess in many javascript-y cases it's not a problem to consider "0" the same as false (or many other comparisons, for that matter), but should this online diff do a !== comparison in the json-patch code here ?
Use case: json strings passed between javascript and non-javascript. If you compare json with json-diff.com and see that there are no changes in the json, while there strictly are changes that the non-javascript backend sees and errors on.
It looks like the diff algorithm here doesn't compare values strictly, A minimal example is:
{"t":"0"}is not different from{"t":false}I guess in many javascript-y cases it's not a problem to consider
"0"the same asfalse(or many other comparisons, for that matter), but should this online diff do a !== comparison in the json-patch code here ?Use case: json strings passed between javascript and non-javascript. If you compare json with json-diff.com and see that there are no changes in the json, while there strictly are changes that the non-javascript backend sees and errors on.