Skip to content

feat: connect 1-click fund flow to Funders section #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidGershony wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: connect 1-click fund flow to Funders section #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9ad9a0
feat: connect 1-click invest flow to Funders section and remove Liqui…
DavidGershony Apr 20, 2026
05cccc1
Merge origin/main into feature/funders-1click-invest (resolve Funders…
dangershony Apr 21, 2026
b18d437
fix: wrap window.Close in try/finally in E2E tests to prevent LiteDB …
DavidGershony Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/design/App.Test.Integration/FundAndRecoverTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ public async Task FullFundAndRecoverFlow()
// ──────────────────────────────────────────────────────────────
TestHelpers.Log("[STEP 0] Booting app with ShellView...");
var window = TestHelpers.CreateShellWindow();
try
{
var shellVm = window.GetShellViewModel();
TestHelpers.Log("[STEP 0] App booted. ShellView created, ShellViewModel ready.");

Expand Down Expand Up @@ -945,9 +947,13 @@ public async Task FullFundAndRecoverFlow()
$"InPenalty={targetInvestment.RecoveryState.HasSpendableItemsInPenalty}, " +
$"ActionKey={targetInvestment.RecoveryState.ActionKey}");

// Cleanup: close window
window.Close();
TestHelpers.Log("========== FullFundAndRecoverFlow PASSED ==========");
}
finally
{
window.Close();
Dispatcher.UIThread.RunJobs();
}
}

}
9 changes: 8 additions & 1 deletion src/design/App.Test.Integration/InvestAndRecoverTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ public async Task FullInvestAndRecoverFlow()
TestHelpers.Log($"[STEP 0] Investment amount: {investmentAmountBtc} BTC");

var window = TestHelpers.CreateShellWindow();
try
{
var shellVm = window.GetShellViewModel();

TestHelpers.Log("[STEP 1] Wiping existing data...");
Expand Down Expand Up @@ -586,8 +588,13 @@ public async Task FullInvestAndRecoverFlow()
targetInvestment.ShowSuccessModal.Should().BeTrue(
$"Recovery operation '{actionKey}' should succeed and show the success modal");

window.Close();
TestHelpers.Log("========== FullInvestAndRecoverFlow PASSED ==========");
}
finally
{
window.Close();
Dispatcher.UIThread.RunJobs();
}
}

private async Task EnsureWalletHasFeeFunds(Window window, string walletId, string context)
Expand Down
7 changes: 2 additions & 5 deletions src/design/App.Test.Integration/InvestModalsViewFixesTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,8 @@ await PumpUntilAsync(
"errors must be tagged with the step that produced them");
}

// Liquid + Import tabs are visual stubs — switching to them does not crash and surfaces a known label.
Log("[7] Stub tabs do not crash...");
vm.SelectNetworkTab(NetworkTab.Liquid);
vm.SelectedNetworkTab.Should().Be(NetworkTab.Liquid);
Comment thread
dangershony marked this conversation as resolved.
vm.InvoiceFieldLabel.Should().Be("Liquid Address");
// Import tab is a visual stub — switching to it does not crash and surfaces a known label.
Log("[7] Stub tab does not crash...");
vm.SelectNetworkTab(NetworkTab.Import);
vm.SelectedNetworkTab.Should().Be(NetworkTab.Import);
vm.InvoiceFieldLabel.Should().Be("Imported Invoice");
Expand Down
Loading
Loading