Smarter example selection by Kvadratni · Pull Request #18 · block/ai-migrate

Kvadratni · 2025-04-01T22:12:30Z

This PR enables intelligent example selection to minimize the impact on context window

[agent] Running example selection analysis...

Example Selection Analysis:
The target files involve a StencilJS component for a modal dialog, which includes properties, methods, events, and CSS styles. The migration involves understanding StencilJS component patterns, event handling, and CSS styling for web components.

Selected Examples:
- MarketCheckbox: Example 1 (MarketCheckbox) is relevant because it demonstrates the use of StencilJS components with properties, methods, and event handling, similar to the target files. It also includes CSS styling for component states, which is applicable to the modal dialog's CSS.
- MarketToggle: Example 3 (MarketToggle) is selected because it shares similar patterns with the target files, such as handling properties, methods, and events in a StencilJS component. The toggle component's interaction logic and CSS styling are relevant to the modal dialog's focus and interaction handling.
- MarketRow: Example 5 (MarketRow) is chosen due to its complex handling of properties, methods, and events in a StencilJS component. It also demonstrates the use of slots and CSS styling, which are crucial for the modal dialog component.

Excluded Examples:
- MarketInlineStatus: Example 2 (MarketInlineStatus) is excluded because it focuses on a simpler component with less complex interaction logic and does not provide additional insights into modal dialog patterns.
- MarketButton: Example 4 (MarketButton) is excluded as it primarily deals with button interactions and does not cover the modal dialog's complexity in terms of focus management and event handling.
- MarketRadio: Example 6 (MarketRadio) is excluded because it focuses on radio button interactions, which are less relevant to the modal dialog's focus and event management complexities.
[agent] Running migration attempt 1

jamadeo

Definitely the right way to go for reducing context. I left some questions about response parsing.

@katzdave has some recent additions to trim the context window when you hit the limit, maybe we should invoke this when we hit that?

jamadeo · 2025-04-02T16:28:45Z

src/ai_migrate/example_selector.py

+                    "excluded_examples": [],
+                }
+            )
+    except Exception as e:


avoid catching Exception, the stack trace should have enough info here

jamadeo · 2025-04-02T16:30:20Z

src/ai_migrate/migrate.py

+    from .example_selector import select_relevant_examples
+
+    log("[agent] Running example selection analysis...")
+    selection_result = await select_relevant_examples(target_files, examples, client)


should we put it behind a flag?

hm good point. which would be the default tho?

src/ai_migrate/example_selector.py

jamadeo · 2025-04-02T16:35:07Z

src/ai_migrate/example_selector.py

+        if "choices" in response and response["choices"]:
+            message = response["choices"][0].get("message", {})
+            if isinstance(message, dict):
+                content = message.get("content", "")
+            else:
+                content = str(message)
+        else:
+            content = str(response)


What's happening here?

this is different format handling, but now I realize it's redundant.

src/ai_migrate/example_selector.py

src/ai_migrate/__init__.py

DOsinga · 2025-04-02T16:42:02Z

src/ai_migrate/utils.py

    deletions: int


+@dataclass


FWIW I am not a fan of having files called utils. It can just mean anything. maybe we can just call this code_handling and move all code handling here? now it just a mixed bag of things max built.

point taken.

DOsinga · 2025-04-02T16:52:20Z

src/ai_migrate/example_selector.py

+                    "excluded_examples": [],
+                }
+            )
+    except Exception as e:


come on, don't catch general Exceptions

src/ai_migrate/example_selector.py

DOsinga · 2025-04-02T16:56:09Z

src/ai_migrate/migrate.py

    if not examples:
        raise FileNotFoundError("No valid example pairs found in examples directory")

+    from .example_selector import select_relevant_examples


DOsinga · 2025-04-02T16:56:56Z

src/ai_migrate/migrate.py

+    from .example_selector import select_relevant_examples
+
+    log("[agent] Running example selection analysis...")
+    selection_result = await select_relevant_examples(target_files, examples, client)


this can throw exceptions, which would stop the whole thing. is that what we want?

if it is not under feature flag - probably yes as there will be no examples.
In case we put it under a flag - probably not

DOsinga · 2025-04-02T16:58:19Z

src/ai_migrate/example_selector.py

+    ]
+
+    response, _ = await client.generate_completion(messages=messages, temperature=0.1)
+


openai allows you to specify json as an output format, which is more reliable than asking for it. you can even specify the format.

yeah, but we aren't using claude? or you mean openAi style client?

we are using databricks which provides an openai client independent of the model we choose I think. of course that's a leaky abstraction so it might not work, but we should give it a shot. it's a useful trick in general

Example selector v1

a5570e0

Kvadratni force-pushed the mnovich/smarter-example-use branch from 3538efc to 38603d0 Compare April 1, 2025 22:13

fixed code block handling

f85387e

Kvadratni force-pushed the mnovich/smarter-example-use branch 2 times, most recently from 9080243 to bba6687 Compare April 1, 2025 22:48

fix tests

f3ca5e1

Kvadratni force-pushed the mnovich/smarter-example-use branch from bba6687 to f3ca5e1 Compare April 1, 2025 22:52

Kvadratni marked this pull request as ready for review April 1, 2025 22:57

format stuff

54b6ad2

jamadeo reviewed Apr 2, 2025

View reviewed changes

DOsinga approved these changes Apr 2, 2025

View reviewed changes

		]

		response, _ = await client.generate_completion(messages=messages, temperature=0.1)

Conversation

Kvadratni commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamadeo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kvadratni Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kvadratni commented Apr 1, 2025 •

edited

Loading

Kvadratni Apr 2, 2025 •

edited

Loading