Conversation
Kvadratni
reviewed
Apr 2, 2025
| tools: list[Tool], | ||
| *, | ||
| context: MigrationContext, | ||
| temperature=0.1, |
Contributor
There was a problem hiding this comment.
just curious why temperature is now a keyword arg?
Collaborator
Author
There was a problem hiding this comment.
There isn't really a hard rule here, but once you start having several args I think it's good practice to make most of them keyword-only. Not to mention if you call this particular one without using the keyword, the value is pretty confusing: call_llm(messages, tools, 0.2) for example.
Kvadratni
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language server clients typically need a root on the filesystem. This passes a minimal migration "context" to every tool call, currently including just the target files and (optionally) the target directory.