Merged
Conversation
…/goose * 'main' of https://github.com/block/ai-migrate: implement support for response_format (#21)
katzdave
changed the title
Kvadratni
reviewed
Apr 7, 2025
src/ai_migrate/migrate.py
Outdated
| for i in range(goose.max_retries): | ||
| log(f"Running migration attempt {i + 1} with Goose") | ||
|
|
||
| if goose.system_prompt: |
Contributor
There was a problem hiding this comment.
not sure the naming here makes sense. this is definitely not a system prompt
src/ai_migrate/migrate.py
Outdated
| The verification output may be large so pipe it to a file verification_output.txt and read it from there. | ||
|
|
||
| Keep trying until the migration passes verification. | ||
| """ |
Contributor
There was a problem hiding this comment.
I don't think this works with goose the same way as an actual system prompt. Goose already has one, so this is being treated as a user prompt. Not sure if any ranking is assigned in the LLM
src/ai_migrate/migrate.py
Outdated
| Keep trying until the migration passes verification. | ||
| """ | ||
|
|
||
| if goose_extra: |
Contributor
There was a problem hiding this comment.
yeah extra is definitely not the system prompt.
src/ai_migrate/migrate.py
Outdated
| target_dir_rel_path: Path | str | None = None, | ||
| target_basename: str = None, | ||
| tools: list[Tool] = None, | ||
| goose: Optional[GooseConfig] = None, |
src/ai_migrate/migrate.py
Outdated
| target_basename: str = "", | ||
| dont_create_evals: bool = False, | ||
| tools: list[Tool] = None, | ||
| goose: Optional[GooseConfig] = None, |
Contributor
There was a problem hiding this comment.
can we rename to goose config?
| verification_output = (stderr or stdout or b"").decode() | ||
| exit_code = verify_process.returncode | ||
|
|
||
| if exit_code > best_exit_code and best_exit_code != 0: |
Contributor
There was a problem hiding this comment.
ok I need some explanation here. how would code 127 be better than 128? Aren't we just hunting for 0 and anything else?
Kvadratni
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.