fix(acp-client): filter non-JSON stdout from local ACP shell initialization#347
Merged
fix(acp-client): filter non-JSON stdout from local ACP shell initialization#347
Conversation
…zation When spawning local ACP agents in an interactive shell, hermit activation messages and other shell init output are written to stdout before `exec` replaces the shell with the agent binary. These non-JSON lines reach the JSON-RPC parser and cause parse errors. Add `normalize_local_acp_stdout` which reads lines from the child's stdout and only forwards those that parse as valid JSON, dropping shell init noise. This mirrors the normalization already applied to remote sessions but with a simpler implementation since local stdout doesn't have the encoding and record-separator concerns of SSH-proxied connections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_local_acp_stdoutto filter non-JSON lines from local ACP child process stdout, matching the existing remote normalization approach.zshrcbanners, plugin messages) from reaching the JSON-RPC parser and crashing the session🤖 Generated with Claude Code