fix(mark): restrict sine wave animation to run-type actions only#352
Merged
fix(mark): restrict sine wave animation to run-type actions only#352
Conversation
Pre-run actions (e.g. npm install) incorrectly displayed the sine wave animation meant for run actions. This adds actionType to RunningActionInfo so the frontend can distinguish action types, guards the default RunPhase fallback on reload to only apply to run actions, and adds an action type check to the secondary actions sine wave rendering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address code review feedback from the previous commit: - Add action_type to Rust ActionStatusEvent so the frontend receives it with status change events - Change RunningActionInfo.actionType from string to ActionType for type safety - Add actionType field to the RunningAction type in BranchCard and populate it at both push sites (status event handler and loadRunningActions) - Replace the actions.find() lookup in the template with execution.actionType, eliminating the race condition where the actions array may not be loaded yet Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionTypetoRunningAction,ActionStatusEvent, and related structs so the frontend knows the action type without re-querying🤖 Generated with Claude Code