feat(desktop): embed linked buzz messages - #3867
Draft
tellaho wants to merge 6 commits into
Draft
Conversation
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Contributor
|
love the embeds. one thing — make sure private/missing messages stay as the plain pill and never fetch content the viewer isnt allowed to see |
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tellaho
force-pushed
the
tho/message-embed
branch
from
August 2, 2026 01:32
8695ae6 to
fc7e64f
Compare
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: new-feature
User Impact: Desktop users can now recognize and open linked Buzz messages from a rich inline preview without losing their place.
Problem: Bare Buzz message permalinks only appeared as compact pills, hiding the quoted context until opened. They also needed a strict disclosure boundary for private, missing, or mismatched sources.
Solution: Bare permalinks now append a bounded, stable-height preview with the source author, avatar, channel, and excerpt only after channel readability and event-channel integrity checks pass. Unreadable or unresolved sources render a neutral non-leaking state, while labeled links remain unchanged and excerpts never recursively unfurl.
Originating Buzz channel:
840b8580-b6f5-4cc5-90ff-6dd78d299ae1File changes
desktop/src/features/messages/lib/messageEmbed.ts
Extracts bare message permalinks, centralizes channel readability and event-integrity checks, and bounds preview excerpts.
desktop/src/features/messages/lib/messageEmbed.test.mjs
Covers extraction, labeled/code exclusions, open and joined-private readability, mismatched source rejection, and excerpt bounds.
desktop/src/shared/ui/markdown/MessageEmbed.tsx
Fetches and renders the privacy-gated message preview with stable loading and neutral unavailable states.
desktop/src/shared/ui/markdown/MessageEmbedList.tsx
Resolves message embeds outside the cached Markdown node tree and appends them with existing attachment layout conventions.
desktop/src/shared/ui/markdown/MessageLinkPill.tsx
Prevents inaccessible links from exposing channel names or offering unsafe navigation.
desktop/src/shared/ui/markdown.tsx
Integrates the message embed list alongside existing rich preview attachments.
desktop/tests/e2e/navigation.spec.ts
Verifies a resolved embed shows source context and opens the linked thread.
Reproduction steps
buzz://message?...permalink.