test(relay): skip 7 PG-dependent media tests when BUZZ_TEST_DATABASE_URL unset (#4080) - #4081
Open
iroiro147 wants to merge 2 commits into
Open
test(relay): skip 7 PG-dependent media tests when BUZZ_TEST_DATABASE_URL unset (#4080)#4081iroiro147 wants to merge 2 commits into
iroiro147 wants to merge 2 commits into
Conversation
…URL unset (block#4080) Default `cargo test -p buzz-relay` on a contributor machine without a local Postgres previously reported 7 spurious PoolTimedOut failures inside api::media::tests. Mark them #[ignore] per the existing fts_integration.rs pattern; they remain runnable via `cargo test -p buzz-relay -- --include-ignored` with BUZZ_TEST_DATABASE_URL set. Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
… BUZZ_TEST_DATABASE_URL unset (block#4083) Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
Author
|
Follow-up: the 2 pre-existing admin-test fails called out above are now fixed in this branch (commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4080.
cargo test -p buzz-relayon a contributor machine without a local Postgres previously reported 9 failures: 7 spuriousSqlx(PoolTimedOut)errors inapi::media::testsplus 2 pre-existing admin-test fails. The 7 media fails are environmental — the tests need Postgres but are plain#[tokio::test]so they run unconditionally.This PR marks them with the same
#[ignore = "requires a live Postgres: set BUZZ_TEST_DATABASE_URL"]pattern already established incrates/buzz-search/tests/fts_integration.rs. They remain runnable via:Tests changed
All inside
crates/buzz-relay/src/api/media.rs::tests:media_get_auth_flag_off_allows_unauthenticated_read_until_sidecar_gatemedia_get_auth_flag_on_rejects_unauthenticated_get_and_head_before_sidecar_gatemedia_get_auth_flag_on_valid_server_scoped_token_reaches_sidecar_gatemedia_get_auth_flag_on_rejects_upload_verb_wrong_server_and_wrong_xmedia_get_auth_flag_on_accepts_range_header_only_after_authupload_rate_limiter_is_scoped_by_communityupload_concurrency_limit_is_scoped_by_communityVerification
Local macOS, no dev Postgres running:
CI behavior is expected to be unchanged, since CI sets
BUZZ_TEST_DATABASE_URLand runs with--include-ignored(or never relied on these tests being default-on in the first place).Out of scope
feedback_attachment_rejects_unknown_feedback,report_detail_rejects_unknown_report) — separate semantic-drift investigation.test_state()soupload_*_scoped_by_communitytests don't need PG at all (they test an in-memory rate limiter and only hit PG viaensure_configured_communityseeding). Tracked in test(relay): skip 7 PG-dependent media tests when BUZZ_TEST_DATABASE_URL unset #4080 as a follow-up.