fix(desktop): route external PR merges to provider - #4090
Draft
hellostatpods wants to merge 1 commit into
Draft
Conversation
Co-authored-by: hellostatpods <hello@statpods.com> Signed-off-by: hellostatpods <hello@statpods.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Desktop preserves external NIP-34 clone URLs, but the review card previously gated Merge only on repository ownership and PR metadata. This allowed GitHub-backed projects to invoke
merge_project_pull_request, whose Rust validation intentionally accepts only/git/<owner>/<repo>URLs on the active Buzz relay.The backend restriction remains unchanged. Broadening it would expose relay-supplied target and source URLs to local Git network operations and would mix Nostr credential handling with external providers.
User impact
Owners of external projects now see an
Open on GitHuborOpen repositoryaction. Relay-hosted projects retain the existing native Merge workflow.Validation
git diff --check: passedjust ci: Rust workspace fmt/clippy, Desktop checks, Desktop Tauri fmt/clippy, and web checks passed; the unrelated mobile step stopped while Hermit downloaded Flutter because the local machine ran out of disk space