Skip to content

fix(desktop): keep hover action bar & reaction pills out of text selection #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iroiro147 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix(desktop): keep hover action bar & reaction pills out of text selection #4105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions desktop/src/features/messages/ui/MessageActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,10 @@ export const MessageActionBar = React.memo(function MessageActionBar({
isReactionPickerOpen || isDropdownOpen
? "sm:pointer-events-auto sm:opacity-100"
: "",
// Issue #4077: the hover action bar is chrome, not message content —
// it must not become part of the surrounding text selection when the
// user drag-selects across a message.
"select-none",
)}
data-testid={`message-action-bar-${message.id}`}
>
Expand Down
4 changes: 4 additions & 0 deletions desktop/src/features/messages/ui/MessageReactions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,10 @@ export function MessageReactions({
<div
className={cn(
"group/reactions mt-1.5 flex flex-wrap items-center gap-1.5",
// Issue #4077: reaction pills and the inline picker are chrome, not
// message content — they must not become part of the surrounding
// text selection when the user drag-selects across a message.
"select-none",
className,
)}
data-testid="message-reactions"
Expand Down