fix(acp): keep all direct-message replies flat - #4240
Open
kerpopule wants to merge 1 commit into
Open
Conversation
Co-authored-by: Steve Darlow <kerpopule@users.noreply.github.com> Signed-off-by: Steve Darlow <kerpopule@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep managed-agent direct messages as a normal flat conversation. Every ordinary DM response is sent at the channel top level, even when the incoming DM carries legacy thread tags. Human-facing channel replies retain their existing thread-root behavior.
This intentionally applies the flat behavior more broadly than #3077. It resolves the top-level case in #3075 and removes the compounding nested-DM behavior described in #2748 by eliminating DM reply anchors rather than moving them to a root.
Implementation
--reply-tofor both top-level and previously threaded DM events.Verification
cargo fmt --all -- --checkenv -u BUZZ_ACP_LAZY_POOL cargo test -p buzz-acp: 662 unit tests and 9 integration tests passedcargo clippy -p buzz-acp --all-targets -- -D warningsjust cireached the mobile suite, where the unrelatedChannelDetailPage keeps follow mode off while a tall newest message stays visibletest failed. This change does not touch mobile code.Fixes #3075.
Addresses #2748 with the product behavior requested here: no threads in direct messages.