Skip to content

Stabilize nested relationship request assertions #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwils merged 1 commit into from
Jul 31, 2026
Merged

Stabilize nested relationship request assertions #1318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions elasticgraph-graphql/spec/acceptance/nested_relationships_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,8 @@ module ElasticGraph
part_args = {order_by: [:id_DESC]} # ensure deterministic ordering of parts
address_args = {order_by: [:full_address_ASC]} # ensure deterministic ordering of addresses

# Nested relationship levels can share an `_msearch` request depending on fiber scheduling, so assert
# the logical search count and routing below rather than the number of transport requests.
[component_args_without_not, component_args_with_not].each do |component_args|
expect {
expect(query_all_relationship_levels_from_widgets(component_args: component_args, part_args: part_args)).to match edges_of(
Expand All @@ -226,7 +228,7 @@ module ElasticGraph
))
))
)
}.to perform_datastore_msearch("main", 6).times.and perform_datastore_search("main", 6).times
}.to perform_datastore_search("main", 6).times

expect_to_have_routed_to_shards_with("main",
# Root `widgets` query isn't filtering on anything and uses no routing.
Expand Down Expand Up @@ -264,7 +266,7 @@ module ElasticGraph
))
)))
)
}.to perform_datastore_msearch("main", 6).times.and perform_datastore_search("main", 6).times
}.to perform_datastore_search("main", 6).times

expect_to_have_routed_to_shards_with("main",
# Root `addresses` query isn't filtering on anything and uses no routing.
Expand Down