PR-1327 followups: drop dead require, tighten percentile test, hoist expect_errors return, drop internal-abstraction spec - #1337
Merged
Conversation
…expect_errors return, drop internal-abstraction spec - rm unused `require "graphql"` in query_adapter.rb (leftover from removed rescue) - percentile_of now brackets [floor,ceil] of nearest-rank instead of full [min,max] - move `return response if expect_errors` into the if-branch in 2 specs - delete function_adapter_spec.rb (tests internal abstraction, not public API); 100% coverage confirmed after removal
myronmarston
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwils,
jwondrusch,
marcdaniels-toast and
rossroberts-toast
as code owners
August 8, 2026 01:09
myronmarston
changed the title
jwils
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are follow ups to #1327:
require "graphql"in query_adapter.rb (leftover from removed rescue)return response if expect_errorsinto the if-branch in 2 specs