fix: avoid load errors when running the release workflow. - #759
Merged
Conversation
|
|
myronmarston
had a problem deploying
to
rubygems.org
August 4, 2025 22:09 — with 
GitHub Actions
Failure
GitHub Actions
Failure
myronmarston
force-pushed
the
myron/fix-release-workflow
branch
from
August 4, 2025 22:18
c2c4dfe to
c40da8e
Compare
myronmarston
had a problem deploying
to
rubygems.org
August 4, 2025 22:18 — with
GitHub Actions
Failure
GitHub Actions
Failure
I just attempted to release ElasticGraph 1.0.0, and ran into load errors from the release workflow. * The initial run[^1] failed due to missing `nokogiri`. * After fixing that, the next run[^2] failed due to missing `redcarpet` and `yard-markdown`. This adds the missing dependencies to the bundle used by the release workflow. These failures are new because #708 updated the YARD build process to require some new dependencies. [^1]: https://github.com/block/elasticgraph/actions/runs/16735183812/job/47372354735 [^2]: https://github.com/block/elasticgraph/actions/runs/16735490788/job/47373323857
myronmarston
force-pushed
the
myron/fix-release-workflow
branch
from
August 4, 2025 22:23
c40da8e to
b826e73
Compare
myronmarston
temporarily deployed
to
rubygems.org
August 4, 2025 22:26 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
myronmarston
marked this pull request as ready for review
August 4, 2025 22:33
zachbutler-squareup
approved these changes
Aug 4, 2025
myronmarston
added a commit
that referenced
this pull request
Aug 19, 2025
The release workflow has broken a couple times recently, and had to be fixed up via #759 and #797. The fact that the workflow is only used when we cut a release means that it does not run super often (and certainly not part of the CI build for each PR!). To help avoid breaking it in the future, I've added a new script, `script/validate_release_workflow`, which validates the brittle part of the release workflow, and I've integrated it into the CI build so that a build will fail if a change would break the release workflow.
myronmarston
added a commit
that referenced
this pull request
Aug 19, 2025
The release workflow has broken a couple times recently, and had to be fixed up via #759 and #797. The fact that the workflow is only used when we cut a release means that it does not run super often (and certainly not part of the CI build for each PR!). To help avoid breaking it in the future, I've added a new script, `script/validate_release_workflow`, which validates the brittle part of the release workflow, and I've integrated it into the CI build so that a build will fail if a change would break the release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just attempted to release ElasticGraph 1.0.0, and ran into load errors from the release workflow.
nokogiri.redcarpetandyard-markdown.This adds the missing dependencies to the bundle used by the release workflow.
These failures are new because #708 updated the YARD build process to require some new dependencies.
I confirmed this fixes the issue by kicking off a dry-run3 of the release workflow against this branch.
Footnotes
https://github.com/block/elasticgraph/actions/runs/16735183812/job/47372354735 ↩
https://github.com/block/elasticgraph/actions/runs/16735490788/job/47373323857 ↩
https://github.com/block/elasticgraph/actions/runs/16735601852 ↩