Skip to content

Improve release workflow. - #994

Merged
myronmarston merged 1 commit into
mainfrom
myron/improve-release-workflow
Jan 26, 2026
Merged

Improve release workflow.#994
myronmarston merged 1 commit into
mainfrom
myron/improve-release-workflow

Conversation

@myronmarston

@myronmarston myronmarston commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Three related fixes:

  1. Bump the version in runtime_metadata.yaml. It embeds the EG version,
    so it must be updated during version bump.

  2. Trigger CI on release PRs via workflow_dispatch.
    PRs created by GITHUB_TOKEN don't trigger pull_request workflows
    (GitHub prevents infinite loops). Now we explicitly trigger CI
    so release PRs get the required status check.

  3. Disable commit signing so tagged commit lands in main.
    create-pull-request with sign-commits: true recreates commits
    via GitHub API with new SHAs, orphaning the tagged commit.

Co-Authored-By: Claude noreply@anthropic.com

@myronmarston
myronmarston changed the base branch from main to myron/fix-version-bump January 23, 2026 23:53
@myronmarston
myronmarston force-pushed the myron/improve-release-workflow branch from 27bb133 to 4f11b21 Compare January 23, 2026 23:53
@myronmarston
myronmarston force-pushed the myron/fix-version-bump branch from 0562772 to 88d217e Compare January 24, 2026 00:28
@myronmarston
myronmarston force-pushed the myron/improve-release-workflow branch from 4f11b21 to 175c078 Compare January 24, 2026 00:40
@myronmarston
myronmarston changed the base branch from myron/fix-version-bump to main January 24, 2026 00:40
@myronmarston myronmarston changed the title Trigger CI on release PRs via workflow_dispatch. Improve release workflow. Jan 24, 2026
@myronmarston
myronmarston force-pushed the myron/improve-release-workflow branch from 175c078 to f22a53f Compare January 24, 2026 00:42
@myronmarston
myronmarston force-pushed the myron/improve-release-workflow branch from f22a53f to c74feeb Compare January 24, 2026 01:22
Three related fixes:

1. Bump the version in `runtime_metadata.yaml`. It embeds the EG version,
   so it must be updated during version bump.

2. Trigger CI on release PRs via workflow_dispatch. PRs created by
   GITHUB_TOKEN don't trigger pull_request workflows (GitHub prevents
   infinite loops). Now we explicitly trigger CI so release PRs get the
   required status check.

3. Disable commit signing so tagged commit lands in main.
   create-pull-request with sign-commits: true recreates commits
   via GitHub API with new SHAs, orphaning the tagged commit.

Co-Authored-By: Claude <noreply@anthropic.com>
@myronmarston
myronmarston merged commit 8ef44e6 into main Jan 26, 2026
23 checks passed
@myronmarston
myronmarston deleted the myron/improve-release-workflow branch January 26, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants