fix(web): correct the wallets page copy on adding an additional wallet - #337
Merged
blockchain-maxis merged 3 commits intoSep 2, 2026
Merged
Conversation
The dashboard told developers to "claim a handle from it in the Identity Registry" to link an additional wallet, but claim() rejects that: it binds a *new* handle to a *new* wallet, so claiming from a second wallet creates a separate, orphaned profile rather than adding to the existing one — undoable only via release + a re-claim. Describe the actual path instead: additional deploy wallets attach to the existing profile via `npx @signet/cli link` from the terminal.
|
@ibochielizabeth-spec Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@ibochielizabeth-spec is attempting to deploy a commit to the blockchainmaxis-8449's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for stellar-signet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
blockchain-maxis
merged commit Sep 2, 2026
6759744
into
blockchain-maxis:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #284
Summary
apps/web/app/(dashboard)/app/wallets/page.tsxtold developers: "To link an additional wallet, claim a handle from it in the Identity Registry — bindings are created on-chain, never from this dashboard."That's not what happens.
claim()inpackages/contracts/identity-registry/src/lib.rsbinds a new handle to a new wallet — it returnsError::WalletAlreadyBoundif the wallet already holds a handle. Claiming from a second wallet doesn't add it to the existing profile; it creates a separate, orphaned profile, recoverable only viareleaseon the new claim plus a re-claim.Changes
claim; attaching an additional deploy wallet to the existing profile is done vianpx @signet/cli linkfrom the terminal (per Scaffold thecli/Go module — the @signet/cli binary #251/CLI has no config file for deployment URL and identity #262, now scaffolded — see feat(cli): scaffold the cli/ Go module for the signet binary #335/feat(cli): read a config file for the deployment URL and last-used identity #336).Verification
pnpm --filter @signet/web typecheck/lint— both pass.