fix(web): clarify unconfigured registry error message (#218) - #347
Merged
blockchain-maxis merged 2 commits intoSep 2, 2026
Merged
Conversation
|
@kaylachi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@kaylachi is attempting to deploy a commit to the blockchainmaxis-8449's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for stellar-signet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…essage Merge resolution: main reformatted the TROUBLESHOOTING table (prettier, via blockchain-maxis#344), so took main's formatting and reapplied this branch's wording change to the one affected cell. The PR changed the status message and its e2e assertion, but the same false claim was left in four other places, which is the thing issue blockchain-maxis#218 is actually about — the copy asserting the contract is not deployed when it is: - docs/TROUBLESHOOTING.md §6 still said 'the Phase 2 message is intentional' and 'unset → Phase 2 copy'; - docs/DEPLOYMENT.md's verification table said 'UI shows Phase 2'; - README.md said the UI 'shows an honest "Phase 2" message'; - the e2e test was still named '…shows the honest Phase 2 state'. All now describe the real condition: the deployment is not configured against a registry. The genuine roadmap uses of 'Phase 2' (README's 'What's coming next', the docs page) are untouched — those are about project phases, not this error. check-docs and the web build pass. Locally the unconfigured e2e case cannot run — my .env bakes NEXT_PUBLIC_IDENTITY_REGISTRY_ID into the build, so the not-configured path never renders; that is the 'build and shell disagree' case the test's own comment describes, and it skips correctly once the shell env matches. CI builds without the id, so it exercises the real path there.
blockchain-maxis
merged commit Sep 2, 2026
6a37686
into
blockchain-maxis:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #218
Summary of Changes
Updates the error status message shown when
NEXT_PUBLIC_IDENTITY_REGISTRY_IDis unset (RegistryNotConfiguredError) to accurately communicate that the local deployment is not configured against an Identity Registry contract, rather than asserting the contract is not deployed.Key Changes
apps/web/app/(marketing)/components/connect-wallet.tsx:setStatuscopy from"On-chain claim launches in Phase 2 — registry not yet deployed."to"On-chain claim is unavailable — this deployment is not configured against an Identity Registry contract."apps/web/e2e/claim.spec.ts:docs/TROUBLESHOOTING.md:Verification Status
node scripts/check-docs.mjs: Passed cleanly (22 markdown files, 27 env vars, no drift).node scripts/check-contract-errors.mjs: Passed cleanly.