Fix #267: Add the /link browser approval page - #355
Conversation
|
@Anambraboi-1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for stellar-signet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Anambraboi-1 is attempting to deploy a commit to the blockchainmaxis-8449's projects Team on Vercel. A member of the Team first needs to authorize it. |
blockchain-maxis
left a comment
blockchain-maxis
left a comment
There was a problem hiding this comment.
The /link approval page is what #267 asks for, and putting it under (dashboard) so it inherits the authenticated layout is the right call. Two blockers.
1. lint • typecheck • test • build fails on this branch (main is green). The Build step:
src/index.ts(10,25): error TS2307: Cannot find module '@stellar/stellar-sdk' or its corresponding type declarations.
apps/cli/src/index.ts imports @stellar/stellar-sdk but apps/cli/package.json never declares it, so the workspace install doesn't hoist it and tsc can't resolve it. Add it as a dependency of apps/cli and commit the lockfile update. e2e smoke tests fails downstream of the same build.
2. apps/cli is a contested location. Same point I left on #353 and #354: the Go CLI series lands at cli/ (#251 scaffolds it, #296 wires it into build/format/lint, #369/#370/#371 open against it). Only one CLI survives. The /link page itself — app/(dashboard)/link/page.tsx — is the substance of #267 and doesn't depend on which CLI wins; that half would merge cleanly on its own.
This branch is stacked on #353 and #354, so it also carries their @/components/button and Account.id errors. Land those two first.
2 participants
Fixes #267. Adds the browser approval page at /link. It parses the CLI pairing code, checks session status (falling back to \SignInGate), validates the user's handle, and renders the Approve/Reject form. The old broken prototype at \�pp/cli/approve/page.tsx\ has been removed.