tracking: CLI non-interactive signing (--sign-with-key / STELLAR_SIGN_WITH_KEY) - #384
Draft
DevTobis wants to merge 1 commit into
Draft
tracking: CLI non-interactive signing (--sign-with-key / STELLAR_SIGN_WITH_KEY)#384DevTobis wants to merge 1 commit into
DevTobis wants to merge 1 commit into
Conversation
…il a CLI exists on main No apps/cli or cli/ package exists on main yet. The CLI is mid-rewrite from a stale TypeScript scaffold (blockchain-maxis#354, apps/cli/) to an in-progress Go rewrite (blockchain-maxis#369 landed identity resolution; blockchain-maxis#370/blockchain-maxis#358/blockchain-maxis#357/blockchain-maxis#359/blockchain-maxis#356/ blockchain-maxis#371/blockchain-maxis#380 build out the rest, all still open). There is no link/sign command yet for --sign-with-key / STELLAR_SIGN_WITH_KEY to attach to. Empty tracking PR so the issue shows linked work in progress. Real commits land once the Go CLI's sign path exists.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Deploy Preview for stellar-signet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #254
Status: blocked, empty tracking PR
No
apps/cliorcli/package exists onmainyet, in either CLI lineage:apps/cli/src/index.ts) — open, stale.feat/cli-stellar-identity) landed identity resolution (cli/internal/keys,signet identity); feat(cli): single-use loopback callback server #370, feat(cli): typed error taxonomy and documented exit codes #358, feat(cli): verify the stellar binary is present and new enough #357, feat(cli): fall back to printing the URL when no browser can be opened #359, ci(cli): add a cross-compile smoke build for the four release targets #356, Wire the Go module into build, format, and lint orchestration #371, docs: specify the Go <-> Rust bridge before the first Rust component lands #380 build out the rest. All still open.Neither has a
link/signcommand yet for--sign-with-keyto attach to or forSTELLAR_SIGN_WITH_KEYto be read by, so there's no real diff to open against this issue right now.One open decision, resolved
PR #352 (
docs/cli-guide) explicitly left a naming question for whoever picks up #254: passSIGNET_DEPLOY_KEYthrough as-is, or readSTELLAR_SIGN_WITH_KEYdirectly (whichstellar tx signalready honours). This issue's own body specifiesSTELLAR_SIGN_WITH_KEY— going with that: CI stores the secret assecrets.SIGNET_DEPLOY_KEYand exposes it to the job asSTELLAR_SIGN_WITH_KEY, one name in the CLI's own environment. No second variable to keep in sync.Next step
Once the Go CLI's sign path exists (after #370 and whichever of the remaining CLI PRs it depends on land), this PR gets the real implementation and comes out of draft.