fix(dashboard): voting on uniswap governor with wrong output#2050
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 UI Review
This PR is a backend logic fix: it swaps the ABI used for The fix only changes how the vote transaction is simulated/submitted under the hood (fixing a Out of scope for a UI review; no findings to report. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97b2dc77b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Note
Medium Risk
Touches on-chain governance vote submission for multiple DAOs, but the change is limited to simulation ABI/decoding and is covered by a new test.
Overview
Fixes "Failed to vote" on GovernorBravo-style governors (e.g. UNI, COMP, GTC, Nouns) where
simulateContractran before the wallet could open.ozGovernorVoteHandlerno longer uses the ENS/OZ governor JSON ABI forcastVote/castVoteWithReason. It now uses a minimalGovernorCastVoteAbiwith emptyoutputs, because Bravo governors return no returndata and viem was erroring when the ABI expected auint256. Proposal IDs are passed asBigInt(params.proposalId)in those calls.A unit test asserts Uniswap governor votes simulate with void-return
castVoteABI and the expected args.Reviewed by Cursor Bugbot for commit 97b2dc7. Configure here.