This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Silent crash of Node#61
Open
matthieu-vincke wants to merge 4 commits into
Open
Conversation
Exception type seems to not be catched by the try/catch in blpapi.js
Exception type seems to not be catched by the try/catch in blpapi.js
Silent crash of Node
Silent crash of Node
Contributor
|
We shouldn't be modifying the vendor dependencies. Instead, we should modify |
Author
|
Hi Eric, I noticed the problem with a request IRDCTK3 such as: service: '//blp/irdctk3', CalcType should be an array but I gave an object and I had this "silent" crash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a silent crash (Exception type seems to not be catched by the invoke try/catch in blpapi.js)
Fix simply consists in changing the throw Exception to throw UnknownErrorException