Skip to content
This repository was archived by the owner on Sep 19, 2018. It is now read-only.

Silent crash of Node#61

Open
matthieu-vincke wants to merge 4 commits into
bloomberg:masterfrom
matthieu-vincke:master
Open

Silent crash of Node#61
matthieu-vincke wants to merge 4 commits into
bloomberg:masterfrom
matthieu-vincke:master

Conversation

@matthieu-vincke
Copy link
Copy Markdown

I noticed a silent crash (Exception type seems to not be catched by the invoke try/catch in blpapi.js)
Fix simply consists in changing the throw Exception to throw UnknownErrorException

Exception type seems to not be catched by the try/catch in blpapi.js
Exception type seems to not be catched by the try/catch in blpapi.js
@ericvw
Copy link
Copy Markdown
Contributor

ericvw commented Apr 23, 2015

We shouldn't be modifying the vendor dependencies. Instead, we should modify blpapijs.cpp to handle the thrown exception. Can you provide an example that reproduces the issue?

@ericvw ericvw self-assigned this Apr 23, 2015
@matthieu-vincke
Copy link
Copy Markdown
Author

Hi Eric,

I noticed the problem with a request IRDCTK3 such as:

service: '//blp/irdctk3',
type: 'GetCurveInterpValues',
req:
{ spotCurve: { curveID: 'CCTK5538d36b1e680009' },
calcType: { calcWhat: 'DF.MID', calcSide: 'DISCOUNTCURVE' } ,
interpPoints:
[ { dayCount: 'DEFAULT',
frequency: 'DEFAULT',
term: { Length: 0, Type: 'MONTHS' } } ] }

CalcType should be an array but I gave an object and I had this "silent" crash.
I will try to see how to modify blpapijs.cpp instead of the .h

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants