Test modsnap against full suite #5517
Conversation
morgando
force-pushed
the
modsnap_default
branch
2 times, most recently
from
053ccf8 to
edb4d40
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 14/19 tests failed ⚠.
The first 10 failing tests are:
sc_force
socksql_master_swings
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
comdb2sys_queueodh_generated
socksql
tunables
reco-ddlk-sql
morgando
force-pushed
the
modsnap_default
branch
from
edb4d40 to
baa1e5b
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
disttxn [core dumped]
analyze_fastinit_race
sc_force
socksql_master_swings
systable_locking
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
queuedb_rollover
sc_versmismatch_logicalsc_generated
morgando
force-pushed
the
modsnap_default
branch
4 times, most recently
from
d4611da to
db54e9b
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 526/627 tests failed ⚠.
The first 10 failing tests are:
disttxn [core dumped]
analyze_fastinit_race
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
queuedb_rollover
sc_versmismatch
sc_versmismatch_logicalsc_generated
recover_deadlock
prepare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 439/627 tests failed ⚠.
The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak [core dumped]
analyze_fastinit_race
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
queuedb_rollover
prepare
selectv_rcode_serialize_reads_like_writes_generated
udf
morgando
force-pushed
the
modsnap_default
branch
3 times, most recently
from
a58b9eb to
ebb9048
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak_starve_generated [core dumped]
tmptbl_leak [core dumped]
analyze_fastinit_race
sc_resume_logicalsc_generated
sc_resume
prepare
selectv_rcode_serialretry_generated
selectv_rcode_disable_svonly_nop_generated
udf
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 145/200 tests failed ⚠.
The first 10 failing tests are:
cldeadlock [setup failure]
disttxn [core dumped]
newsqlreplay
random_osql_replay
sc_lotsoftables
pg_free_recovery
dohsql_race
insert_lots
insert_lots_ssl_generated
epochms_rollover
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
cldeadlock [setup failure]
disttxn [core dumped]
newsqlreplay
random_osql_replay
dohsql_race
queuedb_rollover_noroll1_generated
pg_free_recovery
sc_drop
queuedb_rollover
insert_lots
morgando
force-pushed
the
modsnap_default
branch
from
a84b910 to
8781019
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 71/630 tests failed ⚠.
The first 10 failing tests are:
ssl_san [setup failure]
disttxn [core dumped]
tmptbl_leak_starve_generated [core dumped]
tmptbl_leak [core dumped]
logdelete [core dumped]
schemalk_logicalsc_generated
schemalk_extralock_generated
schemalk
remotecreate_twopc_generated
remotecreate
| @@ -1,7 +1,9 @@ | |||
| (version='1') | |||
There was a problem hiding this comment.
dont understand this test
| @@ -1,3 +1,3 @@ | |||
| (c1='one', comdb2_ctxinfo ( 'parallel' )=1, a=1) | |||
There was a problem hiding this comment.
don't understand this test
morgando
force-pushed
the
modsnap_default
branch
2 times, most recently
from
5278b89 to
23b5ad2
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 50/630 tests failed ⚠.
The first 10 failing tests are:
disttxn [core dumped]
tmptbl_leak [core dumped]
logdelete [core dumped]
logfill
analyze_fastinit_race
remotecreate_twopc_generated
remotecreate
phys_rep_tiered_firstfile_generated
sc_resume_logicalsc_generated
sc_resume
morgando
force-pushed
the
modsnap_default
branch
5 times, most recently
from
5909dd4 to
48fa11f
Compare
morgando
force-pushed
the
modsnap_default
branch
from
b52c3f1 to
3eac95b
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
disttxn [core dumped]
writes_remsql_names_partial_index_off_generated [core dumped]
schemalk
remotecreate_twopc_generated
remotecreate
sc_resume
sc_resume_logicalsc_generated
selectv_partial_index_off_generated
selectv
consumer_non_atomic_default_consumer_generated
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
disttxn [core dumped]
insert_lots_ssl_generated
insert_lots
schemalk
remotecreate
remotecreate_twopc_generated
sc_resume_logicalsc_generated
sc_resume
selectv_partial_index_off_generated
selectv
morgando
force-pushed
the
modsnap_default
branch
from
3eac95b to
7a3bec2
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
Signed-off-by: mdouglas47 <mdouglas47@bloomberg.net>
Signed-off-by: mdouglas47 <mdouglas47@bloomberg.net>
Signed-off-by: mdouglas47 <mdouglas47@bloomberg.net>
morgando
force-pushed
the
modsnap_default
branch
from
7a3bec2 to
b971f5a
Compare
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so run this test in blocksql
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so run this test in blocksql
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so run this test in blocksql
There was a problem hiding this comment.
Added explicit set transaction blocksql in places where this test expects to be running in blocksql
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
This test tests that a bunch of selects that run during schema changes succeed because they go through the recover ddlk process correctly. This is not relevant for snapshot since these selects should fail if we're running in snapshot.
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
Obviously want to run blocksql transactions for blocksql test
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so run this test in blocksql
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so run this test in blocksql
There was a problem hiding this comment.
Now we're running snapshot by default, so do the insert by default.
There was a problem hiding this comment.
Changing txn mode changes order of output here. Talked with rest of team about it and consensus was that this is okay. I'm forgetting the reasoning though.
There was a problem hiding this comment.
rows increase here because the txn can see its own updates.
There was a problem hiding this comment.
Since snapshot is enabled by default, we can run snapshot transactions without enabling any tunables. Updated this test so that the select succeeds.
There was a problem hiding this comment.
Chunk txns don't work in snapshot, so I set mode to blocksql before running chunk txns in this test.
There was a problem hiding this comment.
Test says socksql in name, so set default mode accordingly.
There was a problem hiding this comment.
Transaction is
begin
select nextval('foo')
select curval('foo')
select nextval('foo')
commit
when we're running this test in snapshot isolation, select curval('foo') returns 11 instead of 12. Made a change to reflect this.
2 participants
Uh oh!
There was an error while loading. Please reload this page.