Repository navigation
Conversation
Signed-off-by: Thomas Stephens <tmsteph@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 92.31% 92.32% +0.01%
==========================================
Files 103 103
Lines 13363 13381 +18
Branches 483 484 +1
==========================================
+ Hits 12336 12354 +18
Misses 1027 1027
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hm, can you link to that Debian bug report? Is Debian is building the extension module with one interpreter and then testing it with a different one? |
Signed-off-by: Thomas Stephens <tmsteph1290@gmail.com>
66a13f6 to
70a12b2
Compare
|
Thanks for checking. The Debian bug report is https://bugs.debian.org/1146575 . The mismatch reported is between the Python version encoded in the capture header (3.14.7) and the interpreter used when testing it (3.14.6). This does not by itself prove Debian compiled the extension using a different interpreter; it shows that the recorded and test-time micro versions differ. The patch continues to check the eight-digit header encoding and the major/minor version, while allowing a micro-version difference. |
What could cause that other than building Memray with one interpreter version and then running the tests with a different interpreter version? |
|
I do think there's a Memray bug here, actually - I think we meant to record the version of Python that the capture file was generated with, not the version of Python that the Memray module was compiled with. I'll make sure we're not doing this intentionally, and fix it if not. But separately from that, I'm pretty convinced there's some issue on the Debian side here - is it intentional that you built Memray with Python 3.14.7 but ran the tests with Python 3.14.6? I'd really expect you to use the same Python version (presumably the newly built Python version) to both build Memray and run its test suite. |
|
Closing in favor of #1055 |
Summary
Validation
Signed-off-by: Thomas Stephens tmsteph@users.noreply.github.com