Add improvement plans and architecture decision docs#959
Merged
Conversation
Contributor
Reviewer's GuideAdds a new File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Performance Report for
|
| Metric | Value |
|---|---|
| Total tests | 1479 |
| Total time | 120.79s |
| Mean | 0.0817s |
| Median | 0.0020s |
Top 10 slowest tests
| Test | Time (s) |
|---|---|
test.test_bench_examples.TestBenchExamples::test_example_meta |
17.974 |
test.test_over_time_save_perf::test_save_faster_without_aggregated_tab |
5.068 |
test.test_generated_examples::test_generated_example[regression/example_regression_tuning_drift.py] |
4.466 |
test.test_generated_examples::test_generated_example[result_types/result_image/example_result_image_to_video.py] |
3.511 |
test.test_generated_examples::test_generated_example[cartesian_animation/example_cartesian_animation.py] |
3.065 |
test.test_split_render_examples::test_split_render_subprocess_media |
2.996 |
test.test_split_render_examples::test_split_render_roundtrip[result_image/example_result_image_to_video.py] |
2.775 |
test.test_hash_persistent.TestCrossProcessDeterminism::test_hash_stable_across_two_processes[ResultBool] |
2.757 |
test.test_generated_examples::test_generated_example[regression/example_regression_tuning_step.py] |
2.730 |
test.test_generated_examples::test_generated_example[regression/example_regression_tuning_noise.py] |
2.655 |
Updated by Performance Tracking workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
plans/directory containing self-contained improvement plans and architecture decision documents for the bencher repository. Each plan is written so it can be executed independently by an AI agent or developer.Tactical plans (
plans/01–08):01Release & CI safety — gate PyPI auto-publish on CI passing02Inflight PR triage — 10 open PRs, several stale/conflicting03Repo hygiene — remove stale root-level plan files and dead packaging files04Dependencies & import time — diskcache CVE, numpy floor, extras split, eager imports05Test coverage gaps — ~27 untestedresults/modules, no coverage threshold06Docs & onboarding — README, caching/over_time docs, missing docstrings07Low-risk core cleanup08Larger core refactors (needs owner sign-off)Architecture decision docs (
plans/architecture/):A1Rendering backend unification (plugin registry; resolves Port visualizations from HoloViews/Panel to Plotly (~100x faster save) #830-vs-Plot plugin infrastructure (tier 0, additive) #932)A2Plot selection redesign (ranked, serializable plot specs)A3BenchData contract (one frozen, pickle-free data type) — keystoneA4Caching architecture (one storage interface; absorbs Replace diskcache with minimalkv (CVE-2025-69872) #760 and feat: netCDF-backed history_dir for self-benchmark tracking on RTD #799)plans/README.mdcarries the plan index, recommended ordering, ground rules, and a state-of-the-repo review summary.Test plan
Documentation-only change (markdown under
plans/). No code paths affected; no tests required.🤖 Generated with Claude Code
Summary by Sourcery
Add a structured planning system under a new
plans/directory, including tactical improvement plans and architecture decision documents for rendering, caching, data contracts, tests, docs, CI, and core refactors.Documentation: