ci: record that a skipped required check satisfies the ruleset - #56
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow comment now explains how skipped required checks affect merge status and cites PR ChangesCI staleness gate
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change updates the workflow explanation without changing CI behavior. Edits to docs/coverage.md still trigger Parity, so the coverage check remains in place. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The comment justifying docs/coverage.md as code had this backwards twice. It originally asserted the skipped-counts-as-passing behaviour without evidence; I then removed the assertion on the grounds its premise was false, which conflated two separate claims -- Parity not being required (true at the time, now fixed) with skipped not satisfying required (false). Both are now settled by measurement rather than argument. Parity is a required check on main, and PR #55 reached CLEAN with Lint, Test, Vulnerability Scan and Parity all skipping. So the filter is what keeps a hand-edited accuracy page from merging unmeasured, and it costs ordinary docs PRs nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
aa9b353 to
1305d37
Compare
Comment-only change to
.github/workflows/ci.yml. No behaviour change.The comment justifying
docs/coverage.mdas code got this wrong twice. It first asserted, without evidence, that a skipped required check counts as passing. I then deleted that assertion during the #50 review on the grounds that its premise was false — but that conflated two separate claims:main's ruleset.Both are now settled by measurement rather than argument. PR #55 (docs-only) reached
mergeStateStatus=CLEANwithLint,Test,Vulnerability ScanandParityall reportingskipping, every one of them required onmain.So the filter matters exactly as originally argued: without
docs/coverage.mdin the code class, a PR hand-editing the published OBB rate or deleting the Known Gate 1 violations table would skip Parity, and merge green with a fabricated accuracy figure never measured against the corpus. And because skipped satisfies required, the filter costs ordinary docs PRs nothing — this PR is itself an instance.🤖 Generated with Claude Code
Summary by CodeRabbit