Skip to content

ci: record that a skipped required check satisfies the ruleset - #56

Merged
Lutherwaves merged 1 commit into
mainfrom
ci/skipped-check-note
Sep 24, 2026
Merged

Lutherwaves merged 1 commit into
mainfrom
ci/skipped-check-note

Conversation

@Lutherwaves

@Lutherwaves Lutherwaves commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Comment-only change to .github/workflows/ci.yml. No behaviour change.

The comment justifying docs/coverage.md as code got this wrong twice. It first asserted, without evidence, that a skipped required check counts as passing. I then deleted that assertion during the #50 review on the grounds that its premise was false — but that conflated two separate claims:

  • Parity was not a required check. True at the time. Fixed since: it is now in main's ruleset.
  • A skipped check does not satisfy a required check. False, and that is the claim the comment actually rested on.

Both are now settled by measurement rather than argument. PR #55 (docs-only) reached mergeStateStatus=CLEAN with Lint, Test, Vulnerability Scan and Parity all reporting skipping, every one of them required on main.

So the filter matters exactly as originally argued: without docs/coverage.md in the code class, a PR hand-editing the published OBB rate or deleting the Known Gate 1 violations table would skip Parity, and merge green with a fabricated accuracy figure never measured against the corpus. And because skipped satisfies required, the filter costs ordinary docs PRs nothing — this PR is itself an instance.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated CI workflow comments to clarify how skipped required checks are evaluated and to reflect observed merge-status behavior.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 08c7354b-01f5-493d-8795-c3496c0e55e0

📥 Commits

Reviewing files that changed from the base of the PR and between aa9b353 and 1305d37.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4beebcf0-5548-4127-a196-7264c8b3d930

📥 Commits

Reviewing files that changed from the base of the PR and between 42124ba and aa9b353.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow comment now explains how skipped required checks affect merge status and cites PR #55 as evidence.

Changes

CI staleness gate

Layer / File(s) Summary
Update staleness-gate explanation
.github/workflows/ci.yml
The classification-step comment cites PR #55 and states that skipped required checks can reach mergeStateStatus=CLEAN.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to aa9b3

This change updates the workflow explanation without changing CI behavior. Edits to docs/coverage.md still trigger Parity, so the coverage check remains in place.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: documenting that a skipped required check satisfies the ruleset.
Description check ✅ Passed The description explains what changed, why the comment needed correction, and how the conclusion was verified using PR #55. It does not use the template headings, but it contains the required informat…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The comment justifying docs/coverage.md as code had this backwards twice.
It originally asserted the skipped-counts-as-passing behaviour without
evidence; I then removed the assertion on the grounds its premise was
false, which conflated two separate claims -- Parity not being required
(true at the time, now fixed) with skipped not satisfying required (false).

Both are now settled by measurement rather than argument. Parity is a
required check on main, and PR #55 reached CLEAN with Lint, Test,
Vulnerability Scan and Parity all skipping. So the filter is what keeps a
hand-edited accuracy page from merging unmeasured, and it costs ordinary
docs PRs nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Lutherwaves
Lutherwaves merged commit 96d3c67 into main Sep 24, 2026
11 checks passed
@Lutherwaves
Lutherwaves deleted the ci/skipped-check-note branch September 24, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant