Skip to content

fix(app): Downvote dialog stops switching states before closing. #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin8999 wants to merge 7 commits into
base: main
Choose a base branch
from
+33 −12
Open

fix(app): Downvote dialog stops switching states before closing. #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad1d4a8
fix(app): Close downvote dialog before it switches to "submitted" state
kevin8999 Aug 27, 2026
e368f3e
fix(app): Close downvote dialog before it switches to "unsubmitted" s…
kevin8999 Aug 27, 2026
6c0efe3
fix(app): Change state after DownvoteDialog closes
kevin8999 Sep 1, 2026
5dd9c00
style(app): Rename `onSuccess` to `handleClose` for clarity
kevin8999 Sep 1, 2026
1291b88
Merge branch 'main' into fix/remote-vote-button-during-submission
kevin8999 Sep 1, 2026
3e85a7d
fix(app): Add missing argument to function call
kevin8999 Sep 2, 2026
7cc0978
Merge branch 'main' into fix/remote-vote-button-during-submission
andyrodrigues30 Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions app/src/lib/useVote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export function useVote(
// leaves the buttons showing something that was not stored.
const mutate = async (
run: (id: string) => Promise<MyVote>,
failure: string
failure: string,
handleClose?: () => void
) => {
if (!variantId) return false;
if (!userId) {
Expand All @@ -66,7 +67,16 @@ export function useVote(

setSubmitting(true);
try {
setVote(await run(variantId));
const submission = await run(variantId);

handleClose?.();

const delay = (ms: number) =>
new Promise((resolve) => setTimeout(resolve, ms));
await delay(200);
Comment on lines +74 to +76

@kevin8999 kevin8999 Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delay on the upvote button can optionally be removed by adding a check to see if submission === "up".

Suggested change
const delay = (ms: number) =>
new Promise((resolve) => setTimeout(resolve, ms));
await delay(200);
if (submission === "up") {
const delay = (ms: number) =>
new Promise((resolve) => setTimeout(resolve, ms));
await delay(200);
}


setVote(submission);

await loadTally(variantId);
return true;
} catch {
Expand All @@ -86,17 +96,26 @@ export function useVote(
return castVote(id, { direction: "up" });
}, "Could not save your vote.");

const downvote = (reason: DownvoteReason, note: string) =>
const downvote = (
reason: DownvoteReason,
note: string,
handleClose?: () => void
) =>
mutate(
(id) => castVote(id, { direction: "down", reason, note: note || null }),
"Could not save your downvote."
"Could not save your downvote.",
handleClose
);

const removeVote = () =>
mutate(async (id) => {
await retractVote(id);
return null;
}, "Could not remove your vote.");
const removeVote = (handleClose: () => void) =>
mutate(
async (id) => {
await retractVote(id);
return null;
},
"Could not remove your vote.",
handleClose
);

return { vote, tally, submitting, upvote, downvote, removeVote };
}
2 changes: 1 addition & 1 deletion app/src/routes/guides/$slug/$variantSlug/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ function RouteComponent() {
if (await downvote(reason, note)) setDownvoteOpen(false);
}}
onRemove={async () => {
if (await removeVote()) setDownvoteOpen(false);
await removeVote(() => setDownvoteOpen(false));
}}
/>

Expand Down
6 changes: 4 additions & 2 deletions app/src/routes/guides/$slug/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,12 @@
: null
}
onSubmit={async (reason, note) => {
if (await downvote(reason, note)) setDownvoteOpen(false);
await downvote(reason, note, async () =>

Check warning on line 187 in app/src/routes/guides/$slug/index.tsx

View workflow job for this annotation

GitHub Actions / app · typecheck + lint + build 

Async arrow function has no 'await' expression
setDownvoteOpen(false)
);
}}
onRemove={async () => {
if (await removeVote()) setDownvoteOpen(false);
await removeVote(() => setDownvoteOpen(false));
}}
/>

Expand Down
Loading