feat(profile): add filter by subject in profile activity - #389
Open
rodrigolinhas wants to merge 4 commits into
Open
feat(profile): add filter by subject in profile activity#389rodrigolinhas wants to merge 4 commits into
rodrigolinhas wants to merge 4 commits into
Conversation
- Add subject slug array filter to profileActivitySearchSchema - Add subjects array (slug + name) to profileActivityItemSchema Signed-off-by: Rodrigo Linhas <rodrigolinhas18@gmail.com>
getProfileActivity() now batch-fetches guide_revision_subjects for all guide revision rows in a single query and attaches slug+name pairs to each row. Objective and review rows receive an empty subjects array. Signed-off-by: Rodrigo Linhas <rodrigolinhas18@gmail.com>
- Extend filterActivity() to accept and apply a subject slug filter (OR semantics: a row passes if any of its subjects matches) - Add getActivitySubjectOptions() to derive unique sorted subject choices from the unfiltered activity array - Widen ChoiceColumnFilter to accept 'subject' field alongside 'type'/'status' - Add Subject column to the desktop table header and Subject chip to the mobile filter bar; both are hidden when no subjects are available - Render subject badge chips in desktop table cells and mobile cards - Update hasFilters to include the subject dimension - Expand colSpan of the empty-state row from 6 to 7 Signed-off-by: Rodrigo Linhas <rodrigolinhas18@gmail.com>
rodrigolinhas
requested review from
andyrodrigues30 and
tonylam0
as code owners
September 3, 2026 15:29
rodrigolinhas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows users to filter profile guide activity by subject, following Bluelearn's established query-parameter filtering architecture, schema conventions, and UI patterns.
Closes #383
Type of change
Verification
pnpm -r typecheckpassespnpm -r buildpasses