frontend: use only date-fns to display time for the user#3877
Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom Apr 15, 2026
Merged
frontend: use only date-fns to display time for the user#3877patrickelectric merged 1 commit intobluerobotics:masterfrom
patrickelectric merged 1 commit intobluerobotics:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces javascript-time-ago with date-fns’s formatDistanceToNow for relative time display in Ethernet InterfaceCard and VersionCard components, and removes now-unused time-ago dependencies from the frontend package.json. Class diagram for InterfaceCard and VersionCard time display changesclassDiagram
class InterfaceCard {
+getLeaseExpiryText(expiresAt Date) string
+getLeaseExpiryClass(lease DHCPServerLease) string
}
class VersionCard {
+asTimeAgo(value string) string
+shortSha(value string) string
}
class DateFns {
+formatDistanceToNow(date Date, options Object) string
}
InterfaceCard ..> DateFns : uses
VersionCard ..> DateFns : uses
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- You now duplicate
formatDistanceToNow(..., { addSuffix: true })logic in multiple components; consider extracting a small shared helper (e.g.asTimeAgo(date: Date | string)) to keep formatting consistent and make future changes easier. - In
VersionCard.asTimeAgo, you can simplify and harden the parsing by usingconst date = new Date(value)and returning a fallback ifisNaN(date.getTime()), so invalid timestamps don’t propagate intoformatDistanceToNow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You now duplicate `formatDistanceToNow(..., { addSuffix: true })` logic in multiple components; consider extracting a small shared helper (e.g. `asTimeAgo(date: Date | string)`) to keep formatting consistent and make future changes easier.
- In `VersionCard.asTimeAgo`, you can simplify and harden the parsing by using `const date = new Date(value)` and returning a fallback if `isNaN(date.getTime())`, so invalid timestamps don’t propagate into `formatDistanceToNow`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
patrickelectric
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #1074
Summary by Sourcery
Replace javascript-time-ago with date-fns for relative time display in frontend components and clean up related dependencies.
Enhancements:
Chores: