Skip to content

frontend: kraken: prevent container-not-up icon from overlapping update button #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicoschmdt wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −22
Open

frontend: kraken: prevent container-not-up icon from overlapping update button #3883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 32 additions & 22 deletions core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,29 @@
size="150"
/>
</div>
<v-icon
v-if="extension.enabled && !container && !loading"
v-tooltip="'This extension is enabled but the container is not running.'"
class="container-not-up-alert"
color="warning"
size="35"
>
mdi-robot-dead
</v-icon>
<v-card-title class="pb-1 d-flex justify-space-between align-center">
<div class="d-flex align-center">
<v-avatar
<v-badge
v-if="extensionData && extensionData.extension_logo"
size="60"
class="mr-3"
rounded="0"
v-tooltip="container_not_up ? 'This extension is enabled but the container is not running.' : ''"
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid passing an empty string to v-tooltip when the container is up.

Rather than returning an empty string in the ternary, conditionally apply the tooltip only when container_not_up is true, e.g. v-tooltip="container_not_up && 'This extension is enabled but the container is not running.'" or by wrapping the tooltip in v-if="container_not_up". This prevents creating a tooltip with an empty label, which can lead to odd UX or accessibility behavior.

:value="container_not_up"
overlap
offset-x="7"
offset-y="10"
color="warning"
icon="mdi-robot-dead"
class="mr-3 container-not-up-badge"
>
<v-img
:src="extensionData.extension_logo"
:alt="extension.name"
/>
</v-avatar>
<v-avatar
size="60"
rounded="0"
>
<v-img
:src="extensionData.extension_logo"
:alt="extension.name"
/>
</v-avatar>
</v-badge>
<div>
<div>{{ extension.name }}</div>
<span
Expand Down Expand Up @@ -292,6 +293,9 @@ export default Vue.extend({
buttonBgColor() {
return settings.is_dark_theme ? '#20455e' : '#BDE0F0'
},
container_not_up(): boolean {
return this.extension.enabled && !this.container && !this.loading
},
update_available() : false | string {
if (!this.extensionData) {
return false
Expand Down Expand Up @@ -426,9 +430,15 @@ export default Vue.extend({
z-index: 9999 !important;
}

.container-not-up-alert {
position: absolute;
right: 13px;
top: 13px;
.container-not-up-badge ::v-deep .v-badge__badge {
min-width: 20px;
height: 20px;
padding: 0;
opacity: 0.9;
}

.container-not-up-badge ::v-deep .v-badge__badge .v-icon {
font-size: 18px;
}

</style>
Loading