Update Electron to the latest version#2220
Update Electron to the latest version#2220rafaellehmkuhl wants to merge 3 commits intobluerobotics:masterfrom
Conversation
d1d5534 to
a4c65c2
Compare
ES-Alexander
left a comment
There was a problem hiding this comment.
Did some basic testing (widgets, joystick, video, map, telemetry) on an M4 Macbook Air, and it seemed to work fine.
Would be good if it can be tested with other OSs before merging, and possibly with greater depth of features (especially that Electron might be involved in, like serial connections).
The recommended approach is to use Hash Mode on Electron and History Mode on web. We had the opposite.
a4c65c2 to
8c9ccc3
Compare
|
Putting as draft as in the built version it's opening by default in the mission planning view, and this view is not being rendered. Let's wait and put that in the 1.18 cycle to make things easier. |
|
Reminder of this, since 1.17 is released now. Not sure if this automatically updates electron-updater and electron-builder as well, but if it does then we could potentially make use of Apple’s new icon functionality too, thanks to this change :-) |
An update released during October is believed to increase the performance on macOS significantly (with a strong support other devs, based on the reactions to the mentioned PR).
I also investigated the bug we had last time around blank screens on Windows, and I believe to have fixed it in the 3rd commit (router: Fix reversed history mode).
Needs some extra testing on Windows to make sure there are indeed no new bugs.
Maybe to be merged only after the 1.17.0 stable release.