Add debugging console to the Video Player widget#2291
Open
rafaellehmkuhl wants to merge 2 commits intobluerobotics:masterfrom
Open
Add debugging console to the Video Player widget#2291rafaellehmkuhl wants to merge 2 commits intobluerobotics:masterfrom
rafaellehmkuhl wants to merge 2 commits intobluerobotics:masterfrom
Conversation
Clicking this button basically disconnects the stream from the widget, wait a second and then reconnects. It works well.
rafaellehmkuhl
force-pushed
the
add-debugging-console-video-player
branch
from
b30f136 to
1e788b7
Compare
ArturoManzoli
requested changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Functionality-wise, the feature is working fine.
Still reviewing the code.
From an interface perspective, the Video widget configuration dialog needs a few tweaks:
(0) The dialog needs a X icon on the top right and/or a footer with a close button.
(1) The Vuetify standard collapsible component takes up unnecessary space and does not match our visual identity. I suggest replacing it with our ExpansiblePanel using the compact variant.
(2) The bottom-right and bottom-left margins are too wide; they could be reduced to 10 px.
(3) There is a lot of unused space on the right. The dialog could be about 30% narrower without affecting how its contents are displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.