electron: Re-set window title after page finishes loading#2487
Draft
rafaellehmkuhl wants to merge 1 commit intobluerobotics:masterfrom
Draft
electron: Re-set window title after page finishes loading#2487rafaellehmkuhl wants to merge 1 commit intobluerobotics:masterfrom
rafaellehmkuhl wants to merge 1 commit intobluerobotics:masterfrom
Conversation
Member
Author
|
@ArturoManzoli could you test the binary of this one on Windows to see if it indeed fixes the bug? |
Contributor
Tested over there and the window name is correct, but the app name on the task manager isn't. Take a look:
|
Member
Author
Interesting. Will investigate more. Thanks for the test! |
On Windows the HTML document title could briefly override the Electron window title. Explicitly set it again in did-finish-load to ensure consistency. Closes bluerobotics#2373
rafaellehmkuhl
force-pushed
the
issue-2373-fix-electron-window-title
branch
from
2f73859 to
0787b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the HTML document title could override the Electron window title. Explicitly set it again in did-finish-load to ensure consistency.
Closes #2373