Skip to content

Make sure users review all available extension features (actions and joystick suggestions)#2603

Merged
rafaellehmkuhl merged 5 commits intobluerobotics:masterfrom
rafaellehmkuhl:make-sure-users-check-every-external-features
Apr 21, 2026
Merged

Make sure users review all available extension features (actions and joystick suggestions)#2603
rafaellehmkuhl merged 5 commits intobluerobotics:masterfrom
rafaellehmkuhl:make-sure-users-check-every-external-features

Conversation

@rafaellehmkuhl
Copy link
Copy Markdown
Member

This PR adds two features:

  • If there's a tab in the extension features dialog that has pending items, it blinks it, so it's clear to the user that there are things there
  • It the user tries to close the extension features dialog without dealing with all the features (actions and joystick suggestions), a confirmation dialog is open explaining that to them, so closing without dealing with everything is an explicit decision
Cap.2026-04-20.at.11.31.08.mp4
image

Pulses the opacity of inactive tabs in the external features dialog when
they contain pending actions or joystick suggestions, so users notice
there is still something to review after finishing the first tab.
Intercepts X-button and outside-click dismissals to warn users that
unhandled actions and joystick suggestions will cause the dialog to
reopen on the next Cockpit launch. The confirmation lists each pending
item with its source extension so users can see exactly what is left to
accept or ignore.
Copy link
Copy Markdown
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning is very nice and useful.

Some issue I had:
It feels odd that: applying a suggested mapping will trigger the modal auto-close, thus, triggering the new warning. Is that correct or it was caused by a radCam OPWB key assignment bug?

After applying a suggestion, maybe it should go back to the modal if there are suggestions still to review. And then, if the user try to close the modal, remind them that are still stuff to review

Screenshare.-.2026-04-21.1_43_52.PM.mp4

@rafaellehmkuhl
Copy link
Copy Markdown
Member Author

The warning is very nice and useful.

Some issue I had: It feels odd that: applying a suggested mapping will trigger the modal auto-close, thus, triggering the new warning. Is that correct or it was caused by a radCam OPWB key assignment bug?

After applying a suggestion, maybe it should go back to the modal if there are suggestions still to review. And then, if the user try to close the modal, remind them that are still stuff to review

Agree. I will completely remove the auto-close behavior. It's confusing.

Add a noCloseOnOutsideClick prop to GlassModal that suppresses the
outside-click close behavior without changing the semantics of isPersistent.
This is useful when the modal hosts child dialogs that are teleported outside
the modal's DOM subtree (e.g. Vuetify v-dialogs attached to the document body),
whose clicks would otherwise be interpreted as outside clicks of the modal.
…g clicks

The dialog hosts Vuetify v-dialogs that Vuetify teleports to the document body,
so clicks inside them were detected as outside clicks of the outer GlassModal
and triggered an automatic close once no pending items remained. Opt out of
the outside-click close behavior so the modal stays open after the user applies
the last suggestion and only closes through the explicit close button.
@rafaellehmkuhl
Copy link
Copy Markdown
Member Author

@ArturoManzoli fixed.

Adds a concise confirmation message to the Actions and Joystick Mappings tabs
when every discovered item has already been applied or ignored, so the tab
does not look empty under the collapsed applied/ignored sections.
@rafaellehmkuhl
Copy link
Copy Markdown
Member Author

Also added a new message when all suggestions have been handled:

image

Copy link
Copy Markdown
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now!

@rafaellehmkuhl rafaellehmkuhl merged commit 01d4f01 into bluerobotics:master Apr 21, 2026
11 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the make-sure-users-check-every-external-features branch April 21, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants