Skip to content

Video player widget: Change stream selector's background to dark#2614

Merged
ArturoManzoli merged 1 commit intobluerobotics:masterfrom
ArturoManzoli:2588-video-widget-dropdown-color
Apr 21, 2026
Merged

Video player widget: Change stream selector's background to dark#2614
ArturoManzoli merged 1 commit intobluerobotics:masterfrom
ArturoManzoli:2588-video-widget-dropdown-color

Conversation

@ArturoManzoli
Copy link
Copy Markdown
Contributor

Close #2588

Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
@github-actions
Copy link
Copy Markdown

Automated PR Review (Claude)

0. Summary

Verdict: READY TO MERGE

This PR adds theme="dark" to the v-select stream selector inside the Video Player widget's configuration dialog. This fixes the dropdown background to be dark, matching the surrounding glass-style card. The pattern is widely used across the codebase (20+ instances in other views and components).

1. Correctness & Implementation Bugs

No findings.

2. AGENTS.md Adherence

No findings.

3. Security

  • 3.1 No obfuscated or unreadable code.
  • 3.2 No base64/hex/encoded blobs or binary-like strings.
  • 3.3 No hidden Unicode, zero-width characters, or homoglyph attacks.
  • 3.4 No unexpected network calls or exfiltration patterns.
  • 3.5 No changes to build scripts, CI workflows, or Electron main-process code.
  • 3.6 No secret handling changes, no eval/Function()/v-html additions.
  • 3.7 No new dependencies added.
  • 3.8 No other suspicious patterns.

No findings.

4. Performance

No findings.

5. UI / UX

No findings. The theme="dark" prop ensures the dropdown menu and its items render with dark backgrounds, which is consistent with the parent v-card that uses globalGlassMenuStyles and text-white. The item template already uses text-white and text-gray-400/text-gray-500 classes, so a dark background is the correct choice.

6. Code Quality & Style

No findings.

7. Tests

No findings. A single Vuetify theme prop on a UI component does not warrant new test coverage.

8. Documentation

No findings.

9. Nitpicks / Optional

No findings.

Generated by Claude. This is advisory; a human reviewer must still approve.

@ArturoManzoli ArturoManzoli merged commit 6ba5e05 into bluerobotics:master Apr 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video widget stream dropdown in the config dialog is not following the dark pattern

2 participants