Skip to content

fix: use session: target syntax in list-panes to avoid numeric name ambiguity #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oboote wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use session: target syntax in list-panes to avoid numeric name ambiguity #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/socket_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,9 +730,9 @@ func TestListSessionsOnSocketAllPanes(t *testing.T) {
return "alpha\nbeta", nil
case "list-panes":
switch args[2] {
case "alpha":
case "alpha:":
return "%1\n%3", nil
case "beta":
case "beta:":
return "%7", nil
default:
return "", errors.New("unexpected session")
Expand Down
4 changes: 2 additions & 2 deletions src/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func listSessionsOnSocket(ctx context.Context, cfg config, target socketTarget)
}

func listPaneIDs(ctx context.Context, cfg config, socketPath string, session string) ([]string, error) {
out, err := runTmuxOnSocketFn(ctx, cfg, socketPath, "list-panes", "-t", session, "-F", "#{pane_id}")
out, err := runTmuxOnSocketFn(ctx, cfg, socketPath, "list-panes", "-t", session+":", "-F", "#{pane_id}")
if err != nil {
return nil, err
}
Expand All @@ -269,7 +269,7 @@ func listPaneIDs(ctx context.Context, cfg config, socketPath string, session str
}

func activePaneID(ctx context.Context, cfg config, socketPath string, session string) (string, error) {
out, err := runTmuxOnSocketFn(ctx, cfg, socketPath, "list-panes", "-t", session, "-F", "#{pane_active} #{pane_id}")
out, err := runTmuxOnSocketFn(ctx, cfg, socketPath, "list-panes", "-t", session+":", "-F", "#{pane_active} #{pane_id}")
if err != nil {
return "", err
}
Expand Down